Merge pull request #23 from bfcoder/bf-pid-check

ndbroadbent · web-flow · commit b3156e2efa7b · 2019-05-14T03:31:01.000+07:00
Fix checking convert success
diff --git a/lib/libreconv.rb b/lib/libreconv.rb
@@ -83,7 +83,7 @@ def convert
           *command,
           unsetenv_others: true
         )
-        unless status.success? && error == ''
+        if !status.success?
           raise ConversionFailedError,
                 "Conversion failed! Output: #{output.strip.inspect}, " \
                 "Error: #{error.strip.inspect}"

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ def convert`
`83`	`83`	`*command,`
`84`	`84`	`unsetenv_others: true`
`85`	`85`	`)`
`86`		`- unless status.success? && error == ''`
	`86`	`+ if !status.success?`
`87`	`87`	`raise ConversionFailedError,`
`88`	`88`	`"Conversion failed! Output: #{output.strip.inspect}, " \`
`89`	`89`	`"Error: #{error.strip.inspect}"`