Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gestion des PR #7

Open
xinity opened this issue Jan 16, 2018 · 2 comments
Open

Gestion des PR #7

xinity opened this issue Jan 16, 2018 · 2 comments
Assignees

Comments

@xinity
Copy link
Member

xinity commented Jan 16, 2018

Je propose pour que l'on gère correctement l'evolution de dépot de:

  • chacun créer une branch de feature dans son fork perso du dépot
  • faire des PR dans la branch draft
  • tous sera review dans draft et merge dans master quand c'est ok

Avis ?

@emmanuelCarre
Copy link

Like discuss in issue #2, I continue in english.

I don't like this workflow. You add some content in this repository without review.

So, what is the condition to merge a pull request into draft branch? If no human check, we can automate this step and merge automatically. But what control?
Furthermore, we can be in case: 2 PR are merged into draft branch, the first one need to be rework, the second one is OK. How merge only the second PR?

If you want a step between PR and "production" (master), I prefer some thing like this:

  • The contributor fork this repository, create a branch, do some stuff;
  • The contributor create PR onto draft branch of this repository;
  • Maintainers review the PR;
  • Maintainers merge the PR into draft when it OK;
  • Maintainers merge draft into master.

But, same question... what is the condition to merge draft to master?

In fact, I think the good way is:

  • The contributor contributor create an issue and discuss with the community;
  • The contributor fork this repository, create a branch, do some stuff;
  • The contributor create PR onto master branch of this repository;
  • Maintainers review the PR;
  • Maintainers merge the PR when it OK;

What do you think about this workflow?

@xinity
Copy link
Member Author

xinity commented Jan 18, 2018

while I completely agree with you conceptually , it's too heavy, let me think about it and make another suggestion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants