-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Introduce Chromatic for visual regression tests #730
Conversation
17711ce
to
e4c8ec0
Compare
01fadfb
to
d415f03
Compare
d415f03
to
78a6e40
Compare
d2ae781
to
e169144
Compare
78a6e40
to
721999e
Compare
4759170
to
507265d
Compare
531e73e
to
1f8d62c
Compare
@gnapse I'm going to re-roll as I'll be off the first half of next week. Super interesting though, I'll definitely check it out when I'm back 👍 |
This reverts commit 5deb96e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to view the storybook without the chromatic account.
Was able to create a chromatic account and once in, it showed me the Reactist project. There were two there, one is Reactist
the other is reactist
. I think the former is the one we are really expecting, correct?
Yup. I had not noticed that, and do not know how that other one came into being, but I now removed it. |
Short description
This is work in progress, not even sure it's going to make it tomain
yet.Chromatic is a visual regression testing system provided via an external service (SaaS). It is based on Storybooks (in fact, it's provided by the creators and maintainers of Storybooks). What it does is, it runs your Storybooks stories and creates screenshots of them, which are then used as the basis for comparing when new screenshots are taken in the future.
This PR integrates Chromatic with Reactist's PR builds, so that whenever a PR is created, Chromatic is run and runs the visual regression tests. Via Chromatic's UI, you can review the changes and approve or reject any visual changes that the new PR may have created. More details about this below.
Here’s a sneak peek of what we get with Chromatic:
Snapshot changes need to be approved
Checks in the CI build that come from Chromatic. If there are snapshot differences, they need to be approved in Chromatic’s UI first
Once all changes are approved in Chromatic, the CI step is marked as passed
If the reviewer in Chromatic does not accept all visual changes, the CI step is marked as failed instead
Storybooks instance per PR
Related references
Test plan
We'll take it from there once you see the project in Chromatic. This is mostly to validate that we can all use Chromatic for collaboration.
PR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
Versioning
This does not need to generate a new release, as it's all inward improvements for maintainers only. No new user-facing features are included here.