Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the matching predicate & utility functions from instructions.h to mir.h #27

Open
DontBelieveMe opened this issue Jan 8, 2022 · 0 comments
Open

Move the matching predicate & utility functions from instructions.h to mir.h #27

DontBelieveMe opened this issue Jan 8, 2022 · 0 comments
Assignees
@DontBelieveMe
Labels
codegen Machine/Assembly Code Generation enhancement New feature or request

Comments

@DontBelieveMe
Copy link
Owner

DontBelieveMe commented Jan 8, 2022 •
edited
Loading

It's a bit messy with them being in instructions.h - they are only there because it was the other file I had open at the time... that's laziness for you.

They should be moved to mir.h.

The functions (as it stands) are:

  • stringify_operand
  • is_const_int_with_value
  • is_global
  • is_int
  • is_register
  • is_basic_block

In fact, all of these are reasoning about values & not instructions... sigh
@DontBelieveMe DontBelieveMe self-assigned this Jan 8, 2022
@DontBelieveMe DontBelieveMe added enhancement New feature or request codegen Machine/Assembly Code Generation labels Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DontBelieveMe DontBelieveMe

Labels
codegen Machine/Assembly Code Generation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DontBelieveMe