From 8814bed0aa12c9b05288bed45f0578aabf7d4b0c Mon Sep 17 00:00:00 2001 From: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Date: Tue, 10 Sep 2024 15:47:58 -0500 Subject: [PATCH 1/2] Reworks examine (a little) (#86506) ## About The Pull Request Basically, reworks how examining things looks to the user. #86497 is required even though this pretty much replaces the entire PR. Examining random objects and simplemobs: ![image](https://github.com/user-attachments/assets/a2634a7f-b337-483a-a4e7-699586b4d6ac) ![image](https://github.com/user-attachments/assets/84cfa824-4cb3-4bc1-831c-8db3ccd6b162) Examining a person: ![image](https://github.com/user-attachments/assets/91dc5492-9ba6-44d1-a284-5c97190b12c6) ![image](https://github.com/user-attachments/assets/7af83bea-e364-4daf-9090-551d2ec2b1a1) Examining an ID card a person is wearing (by clicking the hyperlink adorning the ID card when examining them): (Note, you can only pull up this if you are within 3 tiles of the person) ![image](https://github.com/user-attachments/assets/d9658605-0830-4cd2-9b6a-3821f19555c6) ## Why It's Good For The Game Examine is very old and very inconsistent between atoms and mobs. So I thought I could spruce it up a bit while bringing some consistency along. This should also help with losing certain details in massive walls of examine text - stuff like names will stick out more. ## Changelog :cl: Melbert qol: The way examine looks has been updated. qol: A person's ID card no longer appears with a big icon on examine. You can now click on their ID card (in the chat box) to get a bigger picture of it, as well as information about them. refactor: Much of examine backend code has been refactored, report any odd looking text. /:cl: --- code/__DEFINES/chat.dm | 2 + code/__DEFINES/mobs.dm | 4 + code/__DEFINES/span.dm | 5 +- code/datums/elements/ai_held_item.dm | 2 +- code/datums/elements/dextrous.dm | 2 +- .../status_effects/debuffs/fire_stacks.dm | 9 + code/datums/wounds/bones.dm | 18 +- code/datums/wounds/pierce.dm | 18 +- code/game/atom/atom_examine.dm | 43 +- code/game/objects/items/cards_ids.dm | 12 +- .../items/devices/scanners/health_analyzer.dm | 2 +- code/game/objects/items/storage/wallets.dm | 7 +- .../changeling/powers/transform.dm | 6 +- code/modules/clothing/under/_under.dm | 2 +- .../basic/cult/constructs/_construct.dm | 13 +- code/modules/mob/living/basic/drone/_drone.dm | 10 +- .../basic/guardian/guardian_types/dextrous.dm | 2 +- code/modules/mob/living/carbon/examine.dm | 648 ++++++++++++++---- .../mob/living/carbon/human/examine.dm | 450 ------------ code/modules/mob/living/carbon/human/human.dm | 55 +- .../mob/living/carbon/human/human_helpers.dm | 51 +- code/modules/mob/living/silicon/ai/examine.dm | 6 +- .../mob/living/silicon/robot/examine.dm | 12 +- code/modules/mob/mob.dm | 24 +- code/modules/mob/mob_helpers.dm | 9 - .../computers/item/computer.dm | 2 +- tgstation.dme | 1 - .../tgui-panel/styles/tgchat/chat-dark.scss | 55 +- .../tgui-panel/styles/tgchat/chat-light.scss | 44 ++ 29 files changed, 812 insertions(+), 702 deletions(-) delete mode 100644 code/modules/mob/living/carbon/human/examine.dm diff --git a/code/__DEFINES/chat.dm b/code/__DEFINES/chat.dm index c3fe46b0cd496..f4f88df6c706e 100644 --- a/code/__DEFINES/chat.dm +++ b/code/__DEFINES/chat.dm @@ -45,5 +45,7 @@ #define debug_world_log(msg) if (GLOB.Debug2) log_world("DEBUG: [msg]") /// Adds a generic box around whatever message you're sending in chat. Really makes things stand out. #define examine_block(str) ("