Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to build with aeson 2.0 #190

Closed
DougBurke opened this issue Oct 12, 2021 · 2 comments
Closed

unable to build with aeson 2.0 #190

DougBurke opened this issue Oct 12, 2021 · 2 comments

Comments

@DougBurke
Copy link
Owner

So, it looks like the main relevant change is that rather than (Text, Aeson.Value) we now have (Aeson.Key, Aeson.Value) for dictionary elements. hvega has a number of types that have (Text, Value) in them and we can

  • change the type to now use (Key, Value)
  • retain the type and just internally add a bunch of fmap (first Aeson.Key.fromText) using CPP to support old and new aeson.

We could do option 2 (allowing people to use aeson < 2) and then, once aeson 2 support has stabilised in the ecosystem, add option 1 (ie force aeson 2).

It's not clear to me yet whether there's any other change needed, which could complicate things.

@DougBurke
Copy link
Owner Author

We are also blocked (for testing only) by

@DougBurke
Copy link
Owner Author

Closed by #191 (although may need some cabal updates for when aeson-pretty is fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant