Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to new backtrace lib #1049

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

Godones
Copy link
Contributor

@Godones Godones commented Nov 13, 2024

使用新的unwinding库应该可以解决发生的链接错误,同时这个库会正确地释放资源,支持常见的架构。

我关闭了Makefile中的一个检查,因为这个unwinding库中引入了eh_personality,但是cargo clippy会说标准库已经存在,因为kernel使用的工具链是*-linux-gnu。 我暂时不确定这个地方这么去掉这个冲突。

@github-actions github-actions bot added the enhancement New feature or request label Nov 13, 2024
@Godones Godones requested review from fslongjin and Chiichen and removed request for fslongjin November 13, 2024 14:00
@dragonosbot dragonosbot added the S-等待审查 Status: 等待assignee以及相关方的审查。 label Nov 13, 2024
kernel/src/lib.rs Outdated Show resolved Hide resolved
@dragonosbot dragonosbot added O-riscv64 Target: riscv64 O-x86_64 Target: x86_64 labels Nov 14, 2024
kernel/src/lib.rs Show resolved Hide resolved
kernel/src/lib.rs Outdated Show resolved Hide resolved
kernel/src/syscall/mod.rs Outdated Show resolved Hide resolved
kernel/src/syscall/mod.rs Outdated Show resolved Hide resolved
kernel/src/syscall/mod.rs Outdated Show resolved Hide resolved
@fslongjin fslongjin merged commit 081428c into DragonOS-Community:master Nov 19, 2024
7 checks passed
@yuyi2439
Copy link
Contributor

这完全没做离开backtrace feature还能运行的适配
并且这里还有未用到的use

@Godones
Copy link
Contributor Author

Godones commented Nov 20, 2024

这完全没做离开backtrace feature还能运行的适配 并且这里还有未用到的use

似乎是这样的, @fslongjin ,也许我们把backtrace默认开启?

@fslongjin
Copy link
Member

这完全没做离开backtrace feature还能运行的适配 并且这里还有未用到的use

似乎是这样的, @fslongjin ,也许我们把backtrace默认开启?

也许关闭的话能压缩内核大小?不用处理那堆unwind的事情的话。我认为还是得支持关掉这个feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O-riscv64 Target: riscv64 O-x86_64 Target: x86_64 S-等待审查 Status: 等待assignee以及相关方的审查。
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants