Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Hero of the Village" and "Let's Do" charisma beer impact on prices #41

Open
MJRamon opened this issue Jul 15, 2024 · 3 comments

Comments

@MJRamon
Copy link

MJRamon commented Jul 15, 2024

How can we disable "Hero of the Village" and "Let's Do" charisma beer impact on prices?
price_multiplier is set to 0.0.

{
  "tiers": [
    {
      "groups": [
        {
          "num_to_select": 100.0,
          "trades": [
            {
              "cost_a": {
                "type": "minecraft:item",
                "functions": [
                  {
                    "add": false,
                    "count": 10.0,
                    "function": "minecraft:set_count"
                  }
                ],
                "name": "nexus:token_wood"
              },
              "max_uses": 2147483647.0,
              "price_multiplier": 0.0,
              "result": {
                "type": "minecraft:item",
                "name": "nexus:token_copper"
              },
              "reward_experience": false,
              "trader_experience": 0.0
            },
            {
              "cost_a": {
                "type": "minecraft:item",
                "name": "nexus:token_copper"
              },
              "max_uses": 2147483647.0,
              "price_multiplier": 0.0,
              "result": {
                "type": "minecraft:item",
                "functions": [
                  {
                    "add": false,
                    "count": 10.0,
                    "function": "minecraft:set_count"
                  }
                ],
                "name": "nexus:token_wood"
              },
              "reward_experience": false,
              "trader_experience": 0.0
            },


            {
              "cost_a": {
                "type": "minecraft:item",
                "functions": [
                  {
                    "add": false,
                    "count": 10.0,
                    "function": "minecraft:set_count"
                  }
                ],
                "name": "nexus:token_copper"
              },
              "max_uses": 2147483647.0,
              "price_multiplier": 0.0,
              "result": {
                "type": "minecraft:item",
                "name": "nexus:token_silver"
              },
              "reward_experience": false,
              "trader_experience": 0.0
            },
            {
              "cost_a": {
                "type": "minecraft:item",
                "name": "nexus:token_silver"
              },
              "max_uses": 2147483647.0,
              "price_multiplier": 0.0,
              "result": {
                "type": "minecraft:item",
                "functions": [
                  {
                    "add": false,
                    "count": 10.0,
                    "function": "minecraft:set_count"
                  }
                ],
                "name": "nexus:token_copper"
              },
              "reward_experience": false,
              "trader_experience": 0.0
            },


            {
              "cost_a": {
                "type": "minecraft:item",
                "functions": [
                  {
                    "add": false,
                    "count": 10.0,
                    "function": "minecraft:set_count"
                  }
                ],
                "name": "nexus:token_silver"
              },
              "max_uses": 2147483647.0,
              "price_multiplier": 0.0,
              "result": {
                "type": "minecraft:item",
                "name": "nexus:token_gold"
              },
              "reward_experience": false,
              "trader_experience": 0.0
            },
            {
              "cost_a": {
                "type": "minecraft:item",
                "name": "nexus:token_gold"
              },
              "max_uses": 2147483647.0,
              "price_multiplier": 0.0,
              "result": {
                "type": "minecraft:item",
                "functions": [
                  {
                    "add": false,
                    "count": 10.0,
                    "function": "minecraft:set_count"
                  }
                ],
                "name": "nexus:token_silver"
              },
              "reward_experience": false,
              "trader_experience": 0.0
            }



          ]
        }
      ],
      "total_exp_required": 0
    }
  ]
}
@DrexHD
Copy link
Owner

DrexHD commented Jul 15, 2024

Looks like vanilla and charisma don't care about price_multiplier (other reputation does use it). The only option I can give you right now is: Set max_discount in the config to 0 to disable discounts on all trades.

@MJRamon
Copy link
Author

MJRamon commented Jul 15, 2024

Well, setting max_discount isn't an option on a server, as people do rely on vanilla villager trades. Can something be implemented to prevent this for specific traders?

@DrexHD
Copy link
Owner

DrexHD commented Jul 16, 2024

I am currently not very interested in adding this, because it doesn't integrate very cleanly into the vanilla code base, seems rather niche and would require extra mod compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants