Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs missed and restoring back causes crash. #1217

Open
amraei opened this issue Nov 8, 2024 · 11 comments
Open

Tabs missed and restoring back causes crash. #1217

amraei opened this issue Nov 8, 2024 · 11 comments

Comments

@amraei
Copy link

amraei commented Nov 8, 2024

Lately, Sometimes when I close Firefox and open it again, I see that all my groups are empty and there are no tabs in them.
When I try to restore the backup, Firefox crashes.

It used to happen that the groups were empty, but at least the backup could be restored.

  • Ubuntu 24.04.1
  • Firefox 132.0 (64-bit), snap
  • Simple Tab Groups version: 5.2
@glciampaglia
Copy link

Happened to me as well.

  • Pop! OS 22.04 LTS
  • Firefox 132.0 (64 bit), flatpak
  • Simple Tabs Group version: 5.2

@mihalious
Copy link

I had same problem on Firefox 132.0.1, tabs gone and then Firefox crash when trying to restore from backup.

Update to 132.0.2 seems to fix the issue. Backup works without crashing and tabs are not disappearing again

  • Arch Linux
  • Firefox 132.0.2
  • Simple Tabs Group version: 5.2

@ApolloBrazil
Copy link

Same here. Updating to FF 132.0.2 itself didn't fix it for me, but changing browser.tabs.closeWindowWithLastTab to false in about:config seems to have fixed the issue.
Tabs are no longer disappearing for me.

  • Zorin OS 17.2 Core
  • Firefox 132.0.2
  • Simple Tabs Group version: 5.2

@amraei
Copy link
Author

amraei commented Nov 18, 2024

Same here. Updating to FF 132.0.2 itself didn't fix it for me, but changing browser.tabs.closeWindowWithLastTab to false in about:config seems to have fixed the issue. Tabs are no longer disappearing for me.

* Zorin OS 17.2 Core

* Firefox 132.0.2

* Simple Tabs Group version: 5.2

I confirm this also worked for me and backup restored successfully.

@holocronweaver
Copy link

Re-enabling browser.tabs.closeWindowWithLastTab after restoring tabs on FF 132.0.2 had no ill effect. Not sure if setting it false was even needed to restore tabs, but doesn't seem important after the fact.

@treehstn
Copy link

My FF is updated to 133.0 and that's when it started being an issue for me. Can't seem to find where browser.tabs.closeWindowWithLastTab is located to try changing that.

@holocronweaver
Copy link

@treehstn
Copy link

treehstn commented Dec 5, 2024

@treehstn Did you check in about:config? https://support.mozilla.org/en-US/kb/about-config-editor-firefox

Yes... no effect.

@Darxide23
Copy link

I just did a format/reinstall of Windows. Before I did it, though, I made a manual backup of STG. After the reinstall, I tried to restore the manual STG backup, but it will create the tab groups and then start to import the tabs, but it will eventually crash FireFox. When I restart FireFox, only the groups are there. None of the tabs are open anymore. However, if I restore an automatic backup, it's fine. Problem is, my latest automatic backup is 10 days old.

@elehna
Copy link

elehna commented Dec 11, 2024

I had the same issue and discovered some pattern:

  • The tabs only disappeared after closing the last tab of a group.
  • If restoring the backup after reopening Firefox, it would crash unless I had navigated to some website before attempting to restore the backup (so not just having a blank tab open). When I first opened some random website, the backup restoration worked fine.
  • The bug of closing/deleting all tabs after closing the last tab of a group only happened if I had other add-ons enabled. When disabling all other add-ons, STG worked fine. However, I did not find that it was one add-on particular that caused the bug - really any other add-on caused it for me.
  • The bug seemed to first appear after Firefox Update 132.0.1
  • Setting browser.tabs.closeWindowWithLastTab to false does indeed fix this issue. Setting it back to true recreates it.

So to sum up, a temporary solution to this bug is:

  • After crash/losing all your tabs, reopen Firefox and open a random website.
  • Go to STG Settings > Backup your Simple Tab Groups > Restore backup (Click Open backup folder above to locate it)
  • Go to about:config and set browser.tabs.closeWindowWithLastTab.

-> Backup should be restored and bug should not appear anymore.

@VictoriousRaptor
Copy link

I just did a format/reinstall of Windows. Before I did it, though, I made a manual backup of STG. After the reinstall, I tried to restore the manual STG backup, but it will create the tab groups and then start to import the tabs, but it will eventually crash FireFox. When I restart FireFox, only the groups are there. None of the tabs are open anymore. However, if I restore an automatic backup, it's fine. Problem is, my latest automatic backup is 10 days old.

This might help. #1214 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants