Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share setting #573

Open
4 tasks done
takahirom opened this issue Jan 20, 2019 · 7 comments
Open
4 tasks done

Add share setting #573

takahirom opened this issue Jan 20, 2019 · 7 comments

Comments

@takahirom
Copy link
Member

takahirom commented Jan 20, 2019

Kind (Required)

  • Proposal / Discussion

Overview (Required)

  • Setting image is like this

Share Session Option

  • Session Title
  • Session URL(required?)
  • Event hashtag ( #droidkaigi )
  • Room Hashtag ( One of hallA, hallB, room1 ,..., room7 )

This helps share to twitter.

<session title> <session url> <hash tag>...

Full checked tweet(shared text) is below.

マルチモジュールなプロジェクトでテストはどう変わる? https://droidkaigi.jp/2019/timetable/70713 #droidkaigi #hallA

How to do this?

I think we can do it in this step.

You can use settings fragment.

You can observe preference change.
https://stackoverflow.com/a/38599470/4339442

Please create PreferenceActionCreator and PreferenceStore (singleton).

Please use PreferenceStore's field in SessionDetailFragment.

Links

@takahirom takahirom changed the title Add share setting (only add setting items) Add share setting Jan 21, 2019
@jmatsu jmatsu pinned this issue Jan 22, 2019
@jmatsu jmatsu added the easy label Jan 22, 2019
@karyu5b-yuki
Copy link

I wanna try it.

@mhidaka
Copy link
Member

mhidaka commented Jan 22, 2019

@karyu5b-yuki Thank you for your response!
I Assigned you 💪

@takahirom
Copy link
Member Author

@karyu5b-yuki How's your progress on this? Can we help with anything? 😄

@karyu5b-yuki
Copy link

Thank you for asking. I'm working on it.
When is the deadline?

@takahirom
Copy link
Member Author

Version 1.0 deadline is today.
1.1 deadline is not desided. but before DroidKaigi

@karyu5b-yuki
Copy link

I'm really sorry not replying long time.
I tried, but I couldn't finish this task because of my inadequacy.
Again, I'm really sorry.

@karyu5b-yuki
Copy link

@takahirom
I'm very sorry for the late submission.

I want to make it merge, but some problem occurred after PR.
Could you check whether there are some problems in CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants