Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 755: Set background color white except SessionPagesFragment at navigation #760

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Fix issue 755: Set background color white except SessionPagesFragment at navigation #760

merged 1 commit into from
Feb 3, 2019

Conversation

gen0083
Copy link
Contributor

@gen0083 gen0083 commented Feb 3, 2019

Issue

Overview (Required)

  • SessionPagesFragment has red background color, others has no background color (= transparent), then it looks flickering on navigating
  • before implementation, it also changed background color of SessionPagesFragment

Links

Screenshot

Before After
before after

@jmatsu-bot
Copy link
Collaborator

Try it via https://deploygate.com/distributions/f4e949fecebc6388fbc25a57700e8673a96519d3

@jmatsu-bot
Copy link
Collaborator

Apk comparision results

Property Summary
New File Size 8357840 Bytes. (7.97 MB)
File Size Change -211 Bytes. (-0.21 KB)
Download Size Change +673 Bytes. (+0.66 KB)
New Method Reference Count 61204
Method Reference Count Change 0
New Number of dex file(s) 1
Number of dex file(s) Change 0

Generated by 🚫 Danger

@jmatsu-bot
Copy link
Collaborator

Asserted successfully. 💯

Generated by 🚫 Danger

takahirom
takahirom approved these changes Feb 3, 2019
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for navigation adjustments as always 👍
LGTM

@takahirom takahirom merged commit c4a5e5b into DroidKaigi:master Feb 3, 2019
@gen0083 gen0083 deleted the fix_issue_755 branch February 4, 2019 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The space between the bottom sheets is filled with white
3 participants
@gen0083 @jmatsu-bot @takahirom