Skip to content

Commit

Permalink
Merge pull request #792 from DroidKaigi/ios-1.1
Browse files Browse the repository at this point in the history
[iOS] Bump up version to 1.1 and fix loading
  • Loading branch information
ry-itto authored Sep 28, 2022
2 parents 2205920 + 6a38915 commit 808e9e8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.0;
MARKETING_VERSION = 1.1;
PRODUCT_BUNDLE_IDENTIFIER = io.github.droidkaigi.DroidKaigi2022;
PRODUCT_NAME = DroidKaigi2022;
SDKROOT = iphoneos;
Expand Down Expand Up @@ -368,7 +368,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.0;
MARKETING_VERSION = 1.1;
PRODUCT_BUNDLE_IDENTIFIER = io.github.droidkaigi.DroidKaigi2022;
PRODUCT_NAME = DroidKaigi2022;
SDKROOT = iphoneos;
Expand Down
6 changes: 4 additions & 2 deletions app-ios/Sources/TimetableFeature/TimetableView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public let timetableReducer = Reducer<TimetableState, TimetableAction, Timetable
return .none
case let .selectDay(day):
state.selectedDay = day
return .init(value: .refresh)
return .none
case let .setFavorite(id, currentIsFavorite):
return .run { @MainActor _ in
try await environment.sessionsRepository.setFavorite(sessionId: id, favorite: !currentIsFavorite)
Expand Down Expand Up @@ -161,7 +161,9 @@ public struct TimetableView: View {
.animation(.linear(duration: 0.2), value: viewStore.showDate)
}.animation(Animation.easeInOut(duration: 0.3), value: viewStore.state.showSheet)
.task {
await viewStore.send(.refresh).finish()
if viewStore.dayToTimetable.isEmpty {
await viewStore.send(.refresh).finish()
}
}
.foregroundColor(AssetColors.onBackground.swiftUIColor)
.background(AssetColors.background.swiftUIColor)
Expand Down

0 comments on commit 808e9e8

Please sign in to comment.