-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created BaselineProfile for app performance improvement support #732
Conversation
modifier = Modifier.height(height).padding(end = 8.dp).clip(CircleShape) | ||
modifier = Modifier.height(height).padding(end = 8.dp).clip(CircleShape).semantics { | ||
if (day == Day2) { | ||
testTag = "sessionDayTab" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think this makes code change a little difficult. Day2 is not only day tab.
I think we don't have to switch tab at the moment. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. I am late in noticing your comment 🙇
I didn't understand about other influences..
So, remove the semantics
movement and try again 👍
@hiraok hi 👋 This is just a friendly reminder that Issue is now waiting your comment 😉 |
@takahirom |
I wouldn't like to have the baseline profile txt to the repository for repository size and want to use the GitHub artifact ideally. So I made the PR that uses your commits, excluding the profile 🙏 |
This PR is merged in #835 🙏 |
Issue
Overview (Required)
base-profile.txt
to undersrc/main
inapp-android
modulesemantics
to access composables using UIAutomator for create BaselineProfilehttps://developer.android.com/jetpack/compose/testing#uiautomator-interop
Links
Screenshot