Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created BaselineProfile for app performance improvement support #732

Closed
wants to merge 9 commits into from

Conversation

sako810
Copy link
Contributor

@sako810 sako810 commented Sep 24, 2022

Issue

Overview (Required)

Links

Screenshot

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 24, 2022 12:36 Inactive
modifier = Modifier.height(height).padding(end = 8.dp).clip(CircleShape)
modifier = Modifier.height(height).padding(end = 8.dp).clip(CircleShape).semantics {
if (day == Day2) {
testTag = "sessionDayTab"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I think this makes code change a little difficult. Day2 is not only day tab.
I think we don't have to switch tab at the moment. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I am late in noticing your comment 🙇
I didn't understand about other influences..
So, remove the semantics movement and try again 👍

@mhidaka
Copy link
Member

mhidaka commented Sep 29, 2022

@hiraok hi 👋 This is just a friendly reminder that Issue is now waiting your comment 😉

@github-actions github-actions bot temporarily deployed to deploygate-distribution October 2, 2022 00:48 Inactive
@sako810
Copy link
Contributor Author

sako810 commented Oct 3, 2022

@takahirom
I am very sorry for the delay in responding.. 🙇‍♂️
Please check to see if there are any problems 🙏

@sako810 sako810 requested a review from takahirom October 3, 2022 00:12
@takahirom
Copy link
Member

I wouldn't like to have the baseline profile txt to the repository for repository size and want to use the GitHub artifact ideally. So I made the PR that uses your commits, excluding the profile 🙏
#835

@github-actions github-actions bot temporarily deployed to deploygate-distribution October 3, 2022 00:54 Inactive
@takahirom
Copy link
Member

This PR is merged in #835 🙏

@takahirom takahirom closed this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline Profile
3 participants