Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Add title for the license screen #938

Open
fumiya-kume opened this issue Aug 24, 2023 · 4 comments · May be fixed by #1018
Open

[Android] Add title for the license screen #938

fumiya-kume opened this issue Aug 24, 2023 · 4 comments · May be fixed by #1018
Assignees
@fumiya-kume
Labels
welcome contribute

Comments

@fumiya-kume
Copy link
Contributor

Idea Description

Replace to suitable title for the OSS license screen.

Difficulty

Currently, app-android module not yet setup the String resources management system which using StringsBindings.
For this situation, you have to do following items.

  • Setup with StringsBindings at app-android module
  • Call OssLicensesMenuActivity.setActivityTitle with added string

You can refer Official documents as well

Reference images and links
@fumiya-kume fumiya-kume mentioned this issue Aug 24, 2023
Merged
2 tasks
@fumiya-kume fumiya-kume changed the title Add title for the license screen [Android] Add title for the license screen Aug 24, 2023
@takahirom
Copy link
Member

There is AppStrings class so we can utilize it 🙏

@fumiya-kume
Copy link
Contributor Author

Sorry, I want to try this issue 🙇

@takahirom
Copy link
Member

Thanks!

@fumiya-kume
Copy link
Contributor Author

I'd like to confirm the dead line of this task. Is there any strict deadline?
If no, I'd like to try some of improvements with this issue.

Such as (I will reduce the item which low priority maybe

  • Move to own feature module (I won't expand the app module)
  • Fix plugin name by PR review on previous PR 🙇
  • Make screen by Jetpack compose inspired by this blog post
  • Optimize for the foldable devices

@fumiya-kume fumiya-kume linked a pull request Sep 12, 2023 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fumiya-kume fumiya-kume

Labels
welcome contribute
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve OSS licenses screen fumiya-kume/conference-app-2023
2 participants
@takahirom @fumiya-kume