Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the CompareScreenshot CI after merging it from the main branch to the feature branch #483

Closed
takahirom opened this issue Aug 14, 2023 · 3 comments
Closed

Run the CompareScreenshot CI after merging it from the main branch to the feature branch #483

takahirom opened this issue Aug 14, 2023 · 3 comments
Labels
high priority welcome contribute

Comments

@takahirom
Copy link
Member

Idea Description
The screenshot diff appears due to the diff from the timing of the fork, and since the main branch is frequently updated, it becomes very noisy. Therefore, I want to resolve this issue.

https://github.com/DroidKaigi/conference-app-2023/blob/main/.github/workflows/CompareScreenshot.yml

Reference images and links
@takahirom
Copy link
Member Author

I'm going to try this as I feel pain 😭

@takahirom
Copy link
Member Author

Maybe this is because the golden image is old.

@takahirom
Copy link
Member Author

#486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority welcome contribute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@takahirom