Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify displayed items instead of verifying the list's existence in xxxxScreenTest tests #464

Open
takahirom opened this issue Aug 15, 2024 · 7 comments

Comments

@takahirom
Copy link
Member

We should check if the items exist. The list is still a list even when it's empty.

@takahirom takahirom changed the title Verify displayed items instead of verifying the list's existence in tests Verify displayed items instead of verifying the list's existence in xxxxScreenTest tests Aug 15, 2024
@Corvus400
Copy link
Contributor

Corvus400 commented Aug 15, 2024

I would like to work on this issue. ✋
You mean correcting these kinds of tests, right?
#395 (comment)

@takahirom
Copy link
Member Author

Yes, that's what I mean. Thanks!

@iamayushsharmaa
Copy link

I would like to work on this issue
#464

@takahirom
Copy link
Member Author

@iamayushsharmaa Thank you for raising your hand. This issue has already been assigned. However, since there are many screens to fix, if you have a specific screen you'd like to work on, please let me know the name. I think we can collaborate to address this issue.

@iamayushsharmaa
Copy link

yeah sure

@Corvus400
Copy link
Contributor

The contents of FavoritesScreenTest also need to be modified, but we are working on the following PR, so we will check the contents after they are merged and modify them again if there are any shortcomings.
#569

@Corvus400
Copy link
Contributor

Corvus400 commented Aug 18, 2024

Confirmation of remaining tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants