Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design differences in EventMapScreen's Tab should be corrected. #546

Closed
Corvus400 opened this issue Aug 16, 2024 · 6 comments · Fixed by #586
Closed

Design differences in EventMapScreen's Tab should be corrected. #546

Corvus400 opened this issue Aug 16, 2024 · 6 comments · Fixed by #586

Comments

@Corvus400
Copy link
Contributor

As the title suggests, the display is not currently designed to change depending on 1F/B1F.
This feature would need to be implemented as it was last year.

@Corvus400
Copy link
Contributor Author

At any rate, I would like to work on this on my end, as basic functionality should be implemented as quickly as possible. ✋

@Corvus400
Copy link
Contributor Author

Corvus400 commented Aug 17, 2024

@takahirom
I have a question. 🙋‍♂️
Looking at the JSON shown in this Issue, is it unnecessary to filter the EventMap depending on FloorLevel this year? 🤔
Once in this Issue, only the Tab design differences will be corrected. 💪

@Corvus400 Corvus400 changed the title Filter the display of the EventMap by FloorLevel. Fix design differences in EventMapScreen's Tab. Aug 17, 2024
@Corvus400 Corvus400 changed the title Fix design differences in EventMapScreen's Tab. Design differences in EventMapScreen's Tab should be corrected. Aug 17, 2024
@Corvus400
Copy link
Contributor Author

The issue of the Description not being displayed will be addressed in another Issue, so I will not touch that one.
#579

@takahirom
Copy link
Member

the display is not currently designed to change depending on 1F/B1F.

Is 'the display' referring to how we filter the events or not?
Well, we could have events outside the rooms. So I don't think we need to filter the events.

@mhidaka Thank you for handling the event maps. Do you have any opinions about this?

@mhidaka
Copy link
Member

mhidaka commented Aug 18, 2024

Thank you for your suggestion and contrib!

This year's DroidKaigi has no plans to hold any events on the 1st floor. Therefore, We think it would be more convenient to display all events in both cases, whether the map is displayed on the 1st floor or the B1 floor.

@takahirom
Copy link
Member

Thank you for your insight! Let's close this issue. I appreciate your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants