Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe we should share the date with the session sharing #783

Closed
kosenda opened this issue Aug 24, 2024 · 4 comments · Fixed by #904
Closed

Maybe we should share the date with the session sharing #783

kosenda opened this issue Aug 24, 2024 · 4 comments · Fixed by #904

Comments

@kosenda
Copy link
Contributor

kosenda commented Aug 24, 2024

Oveview

Sorry if this is unnecessary 🙇
Currently, the following is shared when you share, but I thought it might be better to have a date.

[Jellyfish] 10:00 - 10:15
Welcome Talk
https://2024.droidkaigi.jp/timetable/85841558-4423-4ce9-859a-83a2a11235c6

fun onShareClick(timetableItem: TimetableItem) {
shareNavigator.share(
"[${timetableItem.room.name.currentLangTitle}] ${timetableItem.startsTimeString} - ${timetableItem.endsTimeString}\n" +
"${timetableItem.title.currentLangTitle}\n" +
timetableItem.url,
)
}

@Corvus400
Copy link
Contributor

I don't remember exactly, but this may be the reason why I did not add the date. 🤔
DroidKaigi/conference-app-2023#1029 (comment)

@takahirom
Copy link
Member

Thanks. I don't think it's a bad idea to have a method just for sharing.

@sadashi-ota
Copy link
Contributor

If it's okay to add this feature, I'd like to do it. 🙋

@takahirom
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants