Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little security concern (maybe?) #17

Open
d4rkd3v1l opened this issue Mar 18, 2021 · 1 comment
Open

Little security concern (maybe?) #17

d4rkd3v1l opened this issue Mar 18, 2021 · 1 comment

Comments

@d4rkd3v1l
Copy link

I was just wondering if it really is a good idea to just push all the parameters into the sonar-project.properties file.
As also stuff like "sonar.login=" will end up there, in plain text.

Maybe using command line arguments instead would solve this?
e.g. -Dsonar.login=<token>

At least Bitrise "redacts" stuff coming from "Secrets" in the build logs.

But as I'm not an info sec pro, I'm not quite sure if that solution is really secure in the end either.

Anyway as a reminder: One should definitely use access tokens that only have the minimum amount of permissions (only "perform analysis" I would ay) and the token should be stored in Bitrise "Secrets".

@koral--
Copy link
Member

koral-- commented Mar 18, 2021

I understand that point of view.
On one hand the properties file (if somehow downloaded from working dir) will contain a plain text with token.
One the other hand its is not printed at all to log unlike commadline invocations. Secrets are stripped but user may hardcode token without saving in a secret.
Moreover the commadline has lesser length limitation than file size. But reaching any of those limits in case of sonar config is not so probable.
There is no a single answer which solution is better I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants