Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_delegatePopoverShouldClose not called in Yosemite #10

Open
graphiclife opened this issue Nov 19, 2014 · 1 comment
Open

_delegatePopoverShouldClose not called in Yosemite #10

graphiclife opened this issue Nov 19, 2014 · 1 comment

Comments

@graphiclife
Copy link

The method

- (BOOL)_delegatePopoverShouldClose:(id)sender

(BFColorPickerPopover:182) is not called in Yosemite when the popover is dismissed by clicking outside, and thus the popover keeps observing changes on the shared color picker, creating some weird behaviour.
@lemonmojo
Copy link

I've also noticed this and found that implementing - (BOOL)popoverShouldClose:(id)sender instead does seem to work correctly. However I'm not sure why _delegatePopoverShouldClose was used, so I can't say for certain that this is the correct approach...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lemonmojo @graphiclife