Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Add solution to Q41 to Q50 of Leetcode #24

Open
9 of 11 tasks
DugarRishab opened this issue Oct 2, 2022 · 31 comments · Fixed by #26, #25, #30 or #33
Open
9 of 11 tasks

[FEATURE]: Add solution to Q41 to Q50 of Leetcode #24

DugarRishab opened this issue Oct 2, 2022 · 31 comments · Fixed by #26, #25, #30 or #33
Assignees
@ZahraShahid @Utsab5 @MehakGupta1103 @kshavgupta
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@DugarRishab
Copy link
Owner

DugarRishab commented Oct 2, 2022 •
edited
Loading

Description:

  • Add the solution of Q41 to Q50 of Leetcode in any language.

Questions:

  • Q40 - cpp
  • Q41 - cpp
  • Q42 - cpp
  • Q43
  • Q44
  • Q45
  • Q46 - java
  • Q47
  • Q48 - cpp
  • Q49
  • Q50 - py

Eligibility Criteria:

  • The solution must not already be there in this repo. If you want to add an alternative to any solution that is already present then mark it as Alternative
  • The solution must pass all tests on Leetcode and do provide a screenshot proving the same.
  • NOTE: Get yourself assigned before sending a PR. PRs regarding this issue from non-assigned people will be marked spam
@DugarRishab DugarRishab added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 2, 2022
@rakshitgondwal
Copy link
Contributor

I would like to work on this issue.

@DugarRishab
Copy link
Owner Author

Hey @rakshitgondwal, I will assign you this issue now.

@HeroKillerStain
Copy link
Contributor

can you pls assign this issue to me

@rakshitgondwal
Copy link
Contributor

@DugarRishab Do i need to provide the the screenshot of test pass for every question in one PR or should I make different PR for different question and provide the screenshot in them?

@DugarRishab
Copy link
Owner Author

@rakshitgondwal both ways are fine by me. Depends on you.

@DugarRishab
Copy link
Owner Author

can you pls assign this issue to me

Yeah, assigning to you now

@DugarRishab
Copy link
Owner Author

DugarRishab commented Oct 2, 2022 •
edited
Loading

@HeroKillerStain and @rakshitgondwal I suggest make separate PRs for each question. That will be better. This way, your PRs will not clash.
Thanks

@rakshitgondwal rakshitgondwal mentioned this issue Oct 2, 2022
Merged
@rakshitgondwal
Copy link
Contributor

@DugarRishab If you could please check the format of the PR ^^

@HeroKillerStain HeroKillerStain mentioned this issue Oct 2, 2022
Merged
@DugarRishab
Copy link
Owner Author

@DugarRishab If you could please check the format of the PR ^^

Some changes were requested and from the next time please give a proper commit message. Thank you

@rakshitgondwal
Copy link
Contributor

@DugarRishab If you could please check the format of the PR ^^

Some changes were requested and from the next time please give a proper commit message. Thank you

Proper commit message how? Would be great if you can specify more.

@DugarRishab
Copy link
Owner Author

@DugarRishab If you could please check the format of the PR ^^

Some changes were requested and from the next time please give a proper commit message. Thank you

Proper commit message how? Would be great if you can specify more.

I meant proper PR title. like: Added solution to Q20

@ZahraShahid
Copy link
Contributor

Can I work on this issue? @DugarRishab

@SohamRatnaparkhi
Copy link
Contributor

SohamRatnaparkhi commented Oct 2, 2022 •
edited
Loading

I would like to solve Q46 ( Combination Sum II)

@DugarRishab
Copy link
Owner Author

Hey @ZahraShahid and @SohamRatnaparkhi I will assign you both.

@rakshitgondwal
Copy link
Contributor

@DugarRishab If you could please check the format of the PR ^^

Some changes were requested and from the next time please give a proper commit message. Thank you

Proper commit message how? Would be great if you can specify more.

I meant proper PR title. like: Added solution to Q20

Sure Sure!

@aryanayush012
Copy link
Contributor

I want to contribute, please assign this to me. @DugarRishab

@DugarRishab DugarRishab reopened this Oct 2, 2022
@ZahraShahid ZahraShahid mentioned this issue Oct 2, 2022
Merged
@DugarRishab
Copy link
Owner Author

I want to contribute, please assign this to me. @DugarRishab

Assigning you now

@DugarRishab DugarRishab reopened this Oct 3, 2022
@vatsal9117
Copy link
Contributor

hey i would like to contribute it please assign me.

@anirudh0806
Copy link

I want to contribute to questions 44 and 45. Please assign.

This was referenced Oct 3, 2022
Merged
Merged
Merged
@aryanayush012 aryanayush012 mentioned this issue Oct 3, 2022
Merged
@DugarRishab
Copy link
Owner Author

I want to contribute to questions 44 and 45. Please assign.

As you can now see, both of them questions are now solved. You can try for other questions.

This was referenced Oct 4, 2022
Closed
Closed
@bmusuko
Copy link

bmusuko commented Oct 4, 2022

Hi @DugarRishab I just pushed solution for question 47 & 49 on #43 & #44
please kindly check it, thank you

@vatsal9117 vatsal9117 mentioned this issue Oct 4, 2022
Closed
@DugarRishab
Copy link
Owner Author

@bmusuko As i have stated earlier and according to our community guidelines, Only assigned people are allowed to contribute to this issue. So i am sorry, but I am gonna have to reject your PRs. I will not mark your PRs as spam because that will get you banned from hacktoberfest.

@MehakGupta1103
Copy link
Contributor

can you assign question 47 to me @DugarRishab

@DugarRishab
Copy link
Owner Author

@MehakGupta1103 go ahead and contribute.

@Utsab5
Copy link
Contributor

Utsab5 commented Oct 15, 2022

Hey @DugarRishab ,
Can you assign me as well?

@DugarRishab
Copy link
Owner Author

hey @Utsab5, assigning you now.

@bhawarth-garg
Copy link
Contributor

can you assign me Q.43,45 &48 @DugarRishab

@DugarRishab
Copy link
Owner Author

can you assign me Q.43,45 &48 @DugarRishab

Yeah, I will assign it to you now.

@bhawarth-garg
Copy link
Contributor

Please check out my PR #83 @DugarRishab

@kshavgupta
Copy link

Hey! @DugarRishab , please assign this issue to me.

@DugarRishab
Copy link
Owner Author

Hey! @DugarRishab , please assign this issue to me.

Okay, I will assign you

@Utsab5 Utsab5 mentioned this issue Oct 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZahraShahid ZahraShahid

@Utsab5 Utsab5

@MehakGupta1103 MehakGupta1103

@kshavgupta kshavgupta

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone