Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix item duplication if possible #7

Open
DustyBagel opened this issue Nov 20, 2023 · 5 comments
Open

Fix item duplication if possible #7

DustyBagel opened this issue Nov 20, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@DustyBagel
Copy link
Collaborator

Because of having elepwer and technic together, some infinite item duplication methods are possible. If possible, we should find a way to get rid of that so that the modpack is able to be used on public servers at some point.

@DustyBagel DustyBagel added the bug Something isn't working label Nov 20, 2023
@DustyDave961
Copy link
Owner

I did deal with the plate duplication bug. Are there any others we should worry about?

@DustyBagel
Copy link
Collaborator Author

Well there is the sandstone duplication thing.

@DustyDave961
Copy link
Owner

DustyDave961 commented Nov 20, 2023

We might be able to fix that if we register the recipes with reduced grinding time, but I haven't tested it yet.

@DustyDave961
Copy link
Owner

I tested your example for clearing the zinc plate recipe for the Elepower compressor, but it didn't work. I can't clear the grinding recipe either. None of the other recipes I tested were cleared. Are you sure you tested both the recipe clearing functions you made?

@DustyBagel
Copy link
Collaborator Author

DustyBagel commented Dec 9, 2023

Yes, I tested them. I tried clearing them again in a new download of the repo and it didn't work for some reason, but I fixed it in pull request #17 as well as some other improvements. Remember when using the elepower_clear_recipe function the item string that you are trying to clear needs to be exactly the same as what it is registered as. For example, if you wanted to clear the recipe for silver_sand you would need to do it like the below example because in the elepower table that the recipe is in has the item output number in it.

elepower_clear_craft("grind", "defualt:silver_sand 4")

There is another issue we need to address too. If any code is below the abms for replacing the ores with stone, it won't run for some reason, and this may be an issue with minetest but I am not completely sure. To avoid this problem, I have put the abms in their own file called ore_overrides.lua.

DustyDave961 added a commit that referenced this issue Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants