Skip to content

Commit

Permalink
Better numpy compatibility (#48)
Browse files Browse the repository at this point in the history
* 🎨 lessen dependencies

* 🔥 remove py3.5 tests

* texmex-python as extra package

* cannot installed with python3.10

* ⭐ fix to be able to use recent numpy

* ⭐ test with recent python

* 3.11 is not yet supported

* not yet compatible with 3.10

---------

Co-authored-by: Keisuke Ogaki <[email protected]>
  • Loading branch information
Hi-king and Keisuke Ogaki authored Oct 16, 2023
1 parent 530f8f9 commit 3cbcce5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
max-parallel: 3
matrix:
platform: [ubuntu-latest]
python-version: ["3.7", "3.8", "3.9"]
python-version: ["3.7", "3.8", "3.9"] # 3.10, 3.11 is not yet supported

steps:
- uses: actions/checkout@v2
Expand Down
6 changes: 3 additions & 3 deletions pqkmeans/encoder/pq_encoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ def fit(self, x_train):
self.Ds = int(D / self.M)
assert self.trained_encoder is None, "fit must be called only once"

codewords = numpy.zeros((self.M, self.Ks, self.Ds), dtype=numpy.float)
codewords = numpy.zeros((self.M, self.Ks, self.Ds), dtype=float)
for m in range(self.M):
x_train_sub = x_train[:, m * self.Ds: (m + 1) * self.Ds].astype(numpy.float)
x_train_sub = x_train[:, m * self.Ds: (m + 1) * self.Ds].astype(float)
codewords[m], _ = kmeans2(x_train_sub, self.Ks, iter=self.iteration, minit='points')
self.trained_encoder = TrainedPQEncoder(codewords, self.code_dtype)

Expand Down Expand Up @@ -66,7 +66,7 @@ def decode_multi(self, codes):
assert M == self.M
assert codes.dtype == self.code_dtype

decoded = numpy.empty((N, self.Ds * self.M), dtype=numpy.float)
decoded = numpy.empty((N, self.Ds * self.M), dtype=float)
for m in range(self.M):
decoded[:, m * self.Ds: (m + 1) * self.Ds] = self.codewords[m][codes[:, m], :]
return decoded

0 comments on commit 3cbcce5

Please sign in to comment.