resolve the highlight bug

DylanDylann · Aug 13, 2024 · 48a3dae · 48a3dae
1 parent a71ed0a
commit 48a3dae
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/src/components/SelectionList/BaseSelectionList.tsx b/src/components/SelectionList/BaseSelectionList.tsx
@@ -538,7 +538,11 @@ function BaseSelectionList<TItem extends ListItem>(
 
     useEffect(() => {
         // Avoid changing focus if the textInputValue remains unchanged.
-        if ((prevTextInputValue === textInputValue && flattenedSections.selectedOptions.length === prevSelectedOptionsLength) || flattenedSections.allOptions.length === 0) {
+        if (
+            (prevTextInputValue === textInputValue && flattenedSections.selectedOptions.length === prevSelectedOptionsLength) ||
+            flattenedSections.allOptions.length === 0 ||
+            shouldUpdateFocusedIndex
+        ) {
             return;
         }
         // Remove the focus if the search input is empty or selected options length is changed (and allOptions length remains the same)
@@ -559,6 +563,7 @@ function BaseSelectionList<TItem extends ListItem>(
         updateAndScrollToFocusedIndex,
         prevSelectedOptionsLength,
         prevAllOptionsLength,
+        shouldUpdateFocusedIndex,
     ]);
 
     useEffect(

diff --git a/...ounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteCustomFieldMappingPicker.tsx b/...ounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteCustomFieldMappingPicker.tsx
@@ -42,6 +42,8 @@ function NetSuiteCustomFieldMappingPicker({value, errorText, onInputChange}: Net
                 }}
                 ListItem={RadioListItem}
                 initiallyFocusedOptionKey={value ?? CONST.INTEGRATION_ENTITY_MAP_TYPES.TAG}
+                shouldSingleExecuteRowSelect
+                shouldUpdateFocusedIndex
             />
             {!!errorText && (
                 <View style={styles.ph5}>

diff --git a/...ccounting/netsuite/import/NetSuiteImportCustomFieldNew/substeps/ChooseSegmentTypeStep.tsx b/...ccounting/netsuite/import/NetSuiteImportCustomFieldNew/substeps/ChooseSegmentTypeStep.tsx
@@ -53,6 +53,8 @@ function ChooseSegmentTypeStep({onNext, customSegmentType, setCustomSegmentType}
                     setSelectedType(selected.value);
                     setIsError(false);
                 }}
+                shouldSingleExecuteRowSelect
+                shouldUpdateFocusedIndex
                 showConfirmButton
                 confirmButtonText={translate('common.next')}
                 onConfirm={onConfirm}

diff --git a/src/pages/workspace/expensifyCard/WorkspaceEditCardLimitTypePage.tsx b/src/pages/workspace/expensifyCard/WorkspaceEditCardLimitTypePage.tsx
@@ -118,6 +118,7 @@ function WorkspaceEditCardLimitTypePage({route}: WorkspaceEditCardLimitTypePageP
                     onSelectRow={({value}) => setTypeSelected(value)}
                     sections={[{data}]}
                     shouldUpdateFocusedIndex
+                    shouldSingleExecuteRowSelect
                     isAlternateTextMultilineSupported
                     initiallyFocusedOptionKey={typeSelected}
                 />