Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compare_xml method for env_batch #4706

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

jasonb5
Copy link
Collaborator

@jasonb5 jasonb5 commented Nov 11, 2024

The existing behavior does not recursively compare some children
of batch_system. This fixes the compare_xml function to correctly
compare submit_args, directives, and queues.

Test suite: pytest CIME/tests/test_unit*
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a

Fixes E3SM-Project/E3SM#6692

User interface changes?: n/a
Update gh-pages html (Y/N)?: n

@jasonb5 jasonb5 self-assigned this Nov 13, 2024
Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you.

Copy link
Contributor

@jgfouca jgfouca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix and test!

@jgfouca jgfouca merged commit 29aa60f into master Nov 20, 2024
7 checks passed
@jgfouca jgfouca deleted the fix_env_batch_compare branch November 20, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting qos in env_batch.xml no longer works
3 participants