Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDAT Migration: Update mp_partition_driver.py to use Dataset from dataset_xr.py #883

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Oct 30, 2024

Description

Analyze files for CDAT migration

  • mp_partition_driver.py -- Two lines for Dataset class from dataset.py, replace with Dataset class from dataset_xr.py
  • mp_partition_parameter.py -- None
  • mp_partition_parser.py -- None
  • mp_partition_plot.py -- None
  • mp_partition_viewer.py -- None

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder changed the title Update mp_partition_driver.py to use Dataset from dataset_xr.py CDAT Migration: Update mp_partition_driver.py to use Dataset from dataset_xr.py Oct 30, 2024
Copy link
Collaborator Author

@tomvothecoder tomvothecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chengzhuzhang, I analyzed all of the mp_partition related modules and only found these changes. Does this set run and if yes, should I test it? I did not try yet.

@chengzhuzhang
Copy link
Contributor

Hi @chengzhuzhang, I analyzed all of the mp_partition related modules and only found these changes. Does this set run and if yes, should I test it? I did not try yet.

This set should run as is, just there is a new enhancement planned to add a new figure that uses new variables from v3 output. Maybe have it a try to see if the code refactor works. Note that this set requires monthly time-series of a set of variables such as, LANDFRAC, T, CLDICE, CLDLIQ exist in test_data_path.

@tomvothecoder
Copy link
Collaborator Author

Hi @chengzhuzhang, I analyzed all of the mp_partition related modules and only found these changes. Does this set run and if yes, should I test it? I did not try yet.

This set should run as is, just there is a new enhancement planned to add a new figure that uses new variables from v3 output. Maybe have it a try to see if the code refactor works. Note that this set requires monthly time-series of a set of variables such as, LANDFRAC, T, CLDICE, CLDLIQ exist in test_data_path.

I forgot that "mp_partition" has been running by default in the run_all..py script. I just ran the code and it successfully generates the plots. There are no visible differences as far as I can tell.

I will merge this PR once the build passes.

@tomvothecoder tomvothecoder merged commit 8b97aa6 into cdat-migration-fy24 Oct 31, 2024
4 checks passed
@tomvothecoder tomvothecoder deleted the refactor/871-mp-partition branch October 31, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants