Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issue in ocean_manufactured_solution_convergence causing PR suite to fail #89

Closed
altheaden opened this issue Jun 22, 2023 · 0 comments · Fixed by #92
Closed

Known issue in ocean_manufactured_solution_convergence causing PR suite to fail #89

altheaden opened this issue Jun 22, 2023 · 0 comments · Fixed by #92
Assignees
Labels
bug Something isn't working ocean Related to ocean tests or analysis

Comments

@altheaden
Copy link
Collaborator

altheaden commented Jun 22, 2023

Hello! I was trying to run the PR suite with the current main branch on Chrysalis, and I ran into an issue:

      Failed
Exception raised while running the steps of the test case
Traceback (most recent call last):
  File "/gpfs/fs1/home/ac.althea/code/polaris/main/polaris/run/serial.py", line 310, in _log_and_run_test
    _run_test(test_case, available_resources)
  File "/gpfs/fs1/home/ac.althea/code/polaris/main/polaris/run/serial.py", line 409, in _run_test
    _run_step(test_case, step, test_case.new_step_log_file,
  File "/gpfs/fs1/home/ac.althea/code/polaris/main/polaris/run/serial.py", line 484, in _run_step
    step.run()
  File "/gpfs/fs1/home/ac.althea/code/polaris/main/polaris/ocean/tests/manufactured_solution/analysis.py", line 76, in run
    raise ValueError(f'order of convergence '
ValueError: order of convergence  0.8311990500398592 < min tolerence 1.8

This is a known issue in the ocean_manufactured_solution_convergence test, causing the analysis step to fail (as mentioned in #72 (comment)).

Ideally, I think the test should be removed from the PR suite until it's not failing anymore so it doesn't impede testing for incoming changes in the meantime (e.g., baseline testing against the main branch).

@altheaden altheaden added bug Something isn't working ocean Related to ocean tests or analysis labels Jun 22, 2023
@xylar xylar self-assigned this Jun 23, 2023
@xylar xylar closed this as completed in #92 Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants