From 4a1c04b840df3dcf608807d2d7fbb9a2f680c639 Mon Sep 17 00:00:00 2001 From: Ekaterina Sakharova Date: Mon, 3 Jun 2024 14:49:16 +0100 Subject: [PATCH] fixes after review --- emgapi/management/commands/populate_metagenomics_exchange.py | 2 +- emgapi/metagenomics_exchange.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emgapi/management/commands/populate_metagenomics_exchange.py b/emgapi/management/commands/populate_metagenomics_exchange.py index 258c3137a..269addca9 100644 --- a/emgapi/management/commands/populate_metagenomics_exchange.py +++ b/emgapi/management/commands/populate_metagenomics_exchange.py @@ -132,7 +132,7 @@ def process_to_index_and_update_records(self, analyses_to_index_and_update): sequence_accession=sequence_accession, ) if not response: - logging.info(f"Error occured {annotation_job}") + logging.warning(f"Error occurred {annotation_job}") continue if response.ok: logging.info(f"Successfully added {annotation_job}") diff --git a/emgapi/metagenomics_exchange.py b/emgapi/metagenomics_exchange.py index 010121765..500ce133d 100644 --- a/emgapi/metagenomics_exchange.py +++ b/emgapi/metagenomics_exchange.py @@ -18,7 +18,7 @@ import requests from django.conf import settings -from requests.exceptions import HTTPError +from requests.exceptions import HTTPError, JSONDecodeError class MetagenomicsExchangeAPI: @@ -114,7 +114,7 @@ def add_analysis(self, mgya: str, sequence_accession: str): try: response_json = http_error.response.json() logging.error(f"API response content: {response_json}") - except ValueError: # Catch JSON decoding errors + except JSONDecodeError: # Catch JSON decoding errors logging.error(f"Failed to decode JSON from response: {http_error.response.text}") except Exception as e: logging.error(f"Unexpected error: {e}")