-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual curation for 2024.03 release #410
Comments
Hello @tcezard @M-casado, here is the curation spreadsheet for this round. Some notes on this one:
|
Ready for review. Couple of extra points:
I think we could have these search precomputed before the spreadsheet is made. That would make the manual curation much faster. |
@apriltuesday pointed me to the documentation on multiple mappings so I change the UNSURE curations by duplicating the rows and add terms that cover different portion of the ClinVar description. |
For the others I'm not really sure whether we should recreate in EFO the intermediate grouping that Mondo obsoleted (so make these NEW terms), or map to the multiple terms as you've done... Mondo seems to have a lot of exclusion rules that I don't know apply to us (or EFO, or Open Targets...). But there might be something problematic about the intermediate grouping that I'm not seeing.... Maybe should wait for @M-casado's input. |
I think that, based on our rubric, we either: (1) import/create a new parent term that distinguishes the inheritance mode; (2) import/create all subtypes to map them extensively; (3) recur to mapping a subtype to a parental type. My experience tells me we ought to do the last one. This is my fear regarding mappings from parent types to subtypes: unless we are extensive on the duplicated mappings, we would be incurring in a wrong and skimmed association. I also changed |
All done for resolving the UNSURE: Thank you @M-casado @apriltuesday |
Thanks all, export done and EFO issue created. |
Refer to documentation for full description of steps.
Checklist:
The text was updated successfully, but these errors were encountered: