Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the events.f90 file #353

Open
femeunier opened this issue Jun 23, 2022 · 3 comments
Open

Typo in the events.f90 file #353

femeunier opened this issue Jun 23, 2022 · 3 comments

Comments

@femeunier
Copy link

There is a small typo when the code is reading the event file in the case of harvest, it shout assign the value to rval(4) instead of rval(3), see and previous lines

call getConfigREAL ('stor_frac','harvest',j,rval(3),texist)

I open an issue for the record, I will prepare a pull request soon.

@pmoorcroft
Copy link

pmoorcroft commented Sep 1, 2022

@femeunier Marcos, Rob and I found a similar issue at lines 138-150 (fertilize lines).

@mpaiao
Copy link
Contributor

mpaiao commented Sep 1, 2022

@femeunier Are you still planning on submitting the pull request? Because you spotted the problem first, it would be better if you created the PR, but we can make one too if you are not planning to submit it.

@femeunier
Copy link
Author

femeunier commented Sep 1, 2022

If you want to proceed rapidly, please go ahead!! I'll leave tomorrow for a conference and will have no time to submit a pull request before a week or so ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants