Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BytesLineReader robustness #26

Open
chipmaurer opened this issue Jul 7, 2021 · 0 comments
Open

BytesLineReader robustness #26

chipmaurer opened this issue Jul 7, 2021 · 0 comments

Comments

@chipmaurer
Copy link
Collaborator

"BytesLineReader.java" has some robustness issues with regard to handling cases that the record exceeds the buffer and record boundaries

Line 46: Need to handle case if record exceeds bufSizeBytes
Line 59: what if non-zero offset and first byte is start of a record? Do we need to look back?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chipmaurer