-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predefined EMMO namespace with checking and label lookup #261
Open
jesper-friis
wants to merge
10
commits into
master
Choose a base branch
from
emmo-namespace
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 79.21% 79.30% +0.09%
==========================================
Files 18 18
Lines 1727 1735 +8
==========================================
+ Hits 1368 1376 +8
Misses 359 359 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable checking and label lookup by default for the EMMO namespace. The following now works out of the box
Also implemented lazy loading of the triplestore when a
Namespace
with checking or label lookup is created. This ensures that we still can import tripper without having rdflib installed, althoughEMMO.Atom
will fail with aModuleNotFoundError
.Added workaround for a design bug in pytest - without the completely unmotivated special handling of the
__wrapped__
attribute pytest would always fail during its collection phase. We should consider to replace pytest with a more decent test framework...Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.