Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 plot Calibration error #99

Closed
mrynik opened this issue Jun 6, 2024 · 1 comment · Fixed by #98
Closed

🐛 plot Calibration error #99

mrynik opened this issue Jun 6, 2024 · 1 comment · Fixed by #98
Assignees
Labels
bug Something isn't working

Comments

@mrynik
Copy link

mrynik commented Jun 6, 2024

Hey, just spotted a bug

This will fail if you pass in the ax object to the _ce_plot function because in that case fig is initialized to None.

fig, ax = plt.subplots(figsize=(6, 6)) if ax is None else (None, ax)

@o-laurent o-laurent self-assigned this Jun 6, 2024
@o-laurent o-laurent added the bug Something isn't working label Jun 6, 2024
@o-laurent
Copy link
Contributor

o-laurent commented Jun 6, 2024

Hi mrynik!

Thank you for the pointer! I pushed a quick fix on dev. We intend to rework the plots a bit in the following releases (#54)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants