Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Github Action for preview deployments #130

Open
sarthakkundra opened this issue Mar 30, 2022 · 2 comments
Open

Feature Request: Github Action for preview deployments #130

sarthakkundra opened this issue Mar 30, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@sarthakkundra
Copy link
Contributor

Is your feature request related to a problem? Please describe.

A lot of times people have to add screenshots/videos for their UI changes in their PRs for the maintainers to verify their changes. This is quite error-prone as maintainers can't check for responsiveness among a lot of other things.

Describe the solution you'd like.

A Github action to deploy all PRs to a preview vercel subdomain which will allow maintainers to easily view and verify changes.

Describe alternatives you've considered

A kubernetes cluster which will deploy on EOS's subdomain but that'll be a ton of work and not that fruitful.

Additional context.

This will also allow us to build on top later on wherein we can check performance changes made on each pull request.

@sarthakkundra sarthakkundra added the enhancement New feature or request label Mar 30, 2022
@ayushsatyam146
Copy link
Contributor

I think the react-preview app might also be considered here. It needs to be configured once by someone with access to repo but after that, we can get separate preview links for every PR and commit by just putting a comment under the PR.
App link - https://github.com/apps/react-preview

@sarthakkundra
Copy link
Contributor Author

@ayushsatyam146 I think this is good for smaller projects but not that customizable in the long run. Would be better to go with a proper deployment service like Vercel, Heroku, etc. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants