Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(style): prevent legend and info overflow #1413

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(style): prevent legend and info overflow #1413

wants to merge 3 commits into from
+15 −0

Conversation

silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented Dec 9, 2024 •
edited
Loading

Implemented changes

This PR adds two small fixes to limit the width of images and legends inside layercontrol:

  • in the info tool, the max-width was limited to 100%
  • in the layer legend, the width was taken from the elements offsetWidth and applied (additional render requested)

Screenshots/Videos

Before

image

After

image

Checklist before requesting a review

@silvester-pari silvester-pari linked an issue Dec 9, 2024 that may be closed by this pull request
Layer legend does not adapt to small layercontrol widths #1343
Open
@netlify Netlify
Copy link

netlify bot commented Dec 9, 2024 •
edited
Loading

✅ Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 8eee372
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/67570d057b983e00086460b4
😎 Deploy Preview https://deploy-preview-1413--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@silvester-pari silvester-pari changed the title Layercontrol/fix/max width fix(style): prevent legend and info overflow Dec 9, 2024
@silvester-pari silvester-pari marked this pull request as ready for review December 9, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-Behairi A-Behairi Awaiting requested review from A-Behairi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layer legend does not adapt to small layercontrol widths
1 participant
@silvester-pari