Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WIP): result action #1424

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented Dec 9, 2024

Implemented changes

TODO

  • PR description
  • Test
  • what if resultActionIcon is undefined
  • better name for property/event
  • docs

Screenshots/Videos

Screencast.from.2024-12-09.17.21.55.webm

Checklist before requesting a review

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 73b51ad
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/675852d3137c45000949f6b1
😎 Deploy Preview https://deploy-preview-1424--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@silvester-pari
Copy link
Collaborator Author

I am questioning the usefulness of this. UX considerations: If the user sees an additional "action" button, (s)he might be tempted to always only click that, as it is not clear the list element can be clicked directly. Maybe there is an other way of achieving a similar result, or we need to first think about how to design this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider prepend & append icons/buttons for list entries Results slot
1 participant