Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and organize drought related recipes #3896

Open
lukruh opened this issue Jan 31, 2025 · 1 comment · May be fixed by #3907
Open

Update and organize drought related recipes #3896

lukruh opened this issue Jan 31, 2025 · 1 comment · May be fixed by #3907

Comments

@lukruh
Copy link
Contributor

lukruh commented Jan 31, 2025

I found some unmaintained recipes related to droughts floating around in the recipe folder:

Some new ones are currently developed. We probably end up with 10 recipes or more. For me it would make sense to group them together in one "Droughts" category in the documentation. This hopefully makes it more organized and visible for users.
Would it also make sense to group the recipe files in a folder (recipes/droughts/...) similar to the diagnostics?

I already discussed with @katjaweigel, that we could start a first PR for updating the documentation and diagnostics to calculate PET, SPI and SPEI (which are used by most of the recipes). I am going to open a draft PR soon. I'd also like to bump the SPEI.R package to v1.8 in the requirements.

@lukruh
Copy link
Contributor Author

lukruh commented Feb 6, 2025

I started over with some updated recipes and diagnostics in diag_scripts/droughts and recipes/droughts. When everything is there we can archive/deprecate the original recipes somehow.

I opened a draft PR to share the current code and documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants