Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve export of invoices #24

Open
jccfd opened this issue Nov 22, 2022 · 0 comments
Open

Improve export of invoices #24

jccfd opened this issue Nov 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jccfd
Copy link

jccfd commented Nov 22, 2022 •
edited
Loading

PDFs were printed on a stream that was removed in Pharo 10.

I fixed it using a memory file system cause they had a similar API, but this is ugly. Maybe Guille or someone knowing the binary streams can help have a better solution?

Impacted methods:

  • ERFinishRegisterAttendeePage>>#downloadInvoice
  • ERInvoiceMailSender>>#getInvoiceAsStreamOf:
  • ERPDFInvoice class>>#streamNamed:
  • ERInvoiceMailSender>>#value
  • ERContainerTab>>#exportInvoiceOf:
@jccfd jccfd added the enhancement New feature or request label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jccfd