-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include dsb step #13
Draft
aricht
wants to merge
17
commits into
main
Choose a base branch
from
include_dsb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Include dsb step #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add script that performs dsb normalization of ADT counts. Script covers normalization without isoform controls. Will be applied to single sample, without hashing.
- remove any functionality about thresholds - make sure that the dsb normalized ADT counts that can be 0 are set to 0 to not break the clustering - save the SCE object including BREMSC clusters, and all UMAP coordinates in the colData - save the colData of the final SCE object as tsv
- rename and adapt script analyse_citeseq_dsb.R - adapt Snakefile_no_hashing to have as default the dsb normalization
- save final results as RDS with SCE but also h5 file
Forgot `optparse` package in script dsb_normalize_adt.R. Added.
- script `dsb_normalize_adt.R`, from rule `dsb_normalize_adt` uses dsb package that is not available in conda - use custom singularity image for this step, instead of conda env
without hashing deconvolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change.
Type of change
Has the appropriate test been performed?
Checklist: