Skip to content

Commit

Permalink
* Remove dependency to iso15118_pip_install_dist, since it isn't need…
Browse files Browse the repository at this point in the history
…ed in most cases

* Refactor name fields of github workflow
* Use `install_everest_testing` instead of `everestpy_pip_install_dist` to make sure using the corresponding everest-testing version in ci

Signed-off-by: Andreas Heinrich <[email protected]>
  • Loading branch information
andistorm committed Dec 11, 2023
1 parent f270e33 commit 1588a60
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .ci/build-kit/test_and_install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
# ninja -j$(nproc) -C build tests
ninja -j$(nproc) -C build install

# install everestpy via cmake target from everest-framework
ninja -C build everestpy_pip_install_dist
# install everest testing by cmake target to make sure using the version defined in dependencies.yaml
ninja -C build install_everest_testing

rsync -a "$EXT_MOUNT/source/tests" ./

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build_and_test.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build and test
name: Build, Lint and Test
on:
pull_request: {}
workflow_dispatch:
Expand All @@ -16,7 +16,7 @@ on:

jobs:
build:
name: Build
name: Build, Lint and Test
runs-on: ${{ inputs.runner || 'ubuntu-22.04' }}
steps:
- name: Format branch name for cache key
Expand Down Expand Up @@ -45,7 +45,7 @@ jobs:
run: |
mkdir scripts
rsync -a source/.ci/build-kit/ scripts
- name: Pull docker container
- name: Pull build-kit image
run: |
docker pull --quiet ghcr.io/everest/build-kit-alpine:latest
docker image tag ghcr.io/everest/build-kit-alpine:latest build-kit
Expand All @@ -55,15 +55,15 @@ jobs:
--volume "$(pwd):/ext" \
--name compile-container \
build-kit run-script compile
- name: Unit tests and install
- name: Create integration-image
run: |
docker commit compile-container build-image
docker run \
--volume "$(pwd):/ext" \
--name test-container \
build-image run-script test_and_install
docker commit test-container integration-image
- name: Run integration tests
run: |
docker commit test-container integration-image
pushd source/.ci/e2e
docker-compose run e2e-test-server run-script tests
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ add_custom_target(install_everest_testing
${PYTHON_EXECUTABLE} -m pip install "${CPM_PACKAGE_everest-utils_SOURCE_DIR}/everest-testing" \;
fi\;
DEPENDS
everestpy_pip_install_dist iso15118_pip_install_dist iso15118_requirements_pip_install_dist
everestpy_pip_install_dist
COMMENT
"Installing dependencies for testing EVerest"
)

0 comments on commit 1588a60

Please sign in to comment.