Skip to content

Commit

Permalink
remove obsolete rcd_enabled config variable (#534)
Browse files Browse the repository at this point in the history
Its implementation and uses were removed in commit
e194737, but partly forgotten, or came back
in with PR #357 in commit da8e936.

Signed-off-by: Moritz Barsnick <[email protected]>
  • Loading branch information
barsnick authored Feb 8, 2024
1 parent 99b066a commit 49ea0bf
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion config/config-sil-dc-sae-v2g.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ active_modules:
config_module:
connector_id: 1
country_code: DE
rcd_enabled: true
evse_id: DE*PNX*E12345*1
evse_id_din: 49A80737A45678
session_logging: true
Expand Down
1 change: 0 additions & 1 deletion config/config-sil-dc-sae-v2h.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ active_modules:
config_module:
connector_id: 1
country_code: DE
rcd_enabled: true
evse_id: DE*PNX*E12345*1
evse_id_din: 49A80737A45678
session_logging: true
Expand Down
2 changes: 0 additions & 2 deletions config/config-sil-ocpp-pnc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ active_modules:
three_phases: true
has_ventilation: true
country_code: DE
rcd_enabled: true
evse_id: "DE*PNX*00001"
session_logging: true
session_logging_xml: false
Expand Down Expand Up @@ -51,7 +50,6 @@ active_modules:
three_phases: true
has_ventilation: true
country_code: DE
rcd_enabled: true
evse_id: "2"
session_logging: true
session_logging_xml: false
Expand Down
3 changes: 1 addition & 2 deletions modules/simulation/JsYetiSimulator/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ function simulation_statemachine(mod) {
}

function check_error_rcd(mod) {
if (mod.rcd_enabled && mod.simulation_data.rcd_current > 5.0) {
if (mod.simulation_data.rcd_current > 5.0) {
if (!mod.rcd_error_reported) {
mod.provides.rcd.raise.ac_rcd_DC('Simulated fault event', 'High');
mod.rcd_error_reported = true;
Expand Down Expand Up @@ -984,7 +984,6 @@ function clearData(mod) {
mod.has_ventilation = false;

mod.rcd_current = 0.1;
mod.rcd_enabled = true;
mod.rcd_error = false;
mod.rcd_error_reported = false;

Expand Down

0 comments on commit 49ea0bf

Please sign in to comment.