-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests that simply run all (SIL) configs in everest-core/config #437
Conversation
023fe68
to
cf55dcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The multiplied, same-functionality code should be generalized (see comment).
How long will these tests take? Tried to answer myself but the tests are currently failing on initialisation. If it takes too long, one option would be to run them in parallel. But unfortunately, GitHub Actions doesn't support this out of the box, AFAIK. CircleCI has a neat helper for it. But perhaps there's a good tool for GitHub Actions, too. |
Sorry, clicked wrong 🙈 |
Let's see how long they take, them failing right now is already being worked on (basically we use a version of everest-testing that's too old in the ci tests) |
Yeah, there are tools for GitHub Actions. Was quite simple to find searching for "split tests":
|
All 15 tests that are implemented right now run sequentially and take ~67 seconds, so <5s/test. Codacy for example usually takes much longer than that, so I think this is negligible for now. |
43b21fa
to
9c54906
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with comments (in the meaning: I'm sure you'll address my comments.)
9b2b170
to
d46a0aa
Compare
d46a0aa
to
189b7c0
Compare
189b7c0
to
fb36b0e
Compare
For this PR to work we need to have these merged: |
ceceaba
to
5f04f34
Compare
fdd926f
to
29e80e3
Compare
29e80e3
to
2e538ca
Compare
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
d406dbb
to
fcd141d
Compare
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
90f99e3
to
cdedd6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Co-authored-by: Andreas Heinrich <[email protected]> Signed-off-by: Kai-Uwe Hermann <[email protected]>
cdedd6c
to
aefeb59
Compare
This should help in finding regressions that need configuration changes or detect broken configs