enhanced wifi setup #504
Merged
enhanced wifi setup #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
approved these changes
Jan 23, 2024
feat: support configuragion for connecting to hidden WiFi networks feat: simplified specialising WiFi setup fix: refactored WiFi config code to separate class fix: added some unit tests Note to connect to a hidden network an additional MQTT argument will be needed. Signed-off-by: James Chapman <[email protected]>
Signed-off-by: James Chapman <[email protected]>
corneliusclaussen
force-pushed
the
jc/enhanced-wifi-setup
branch
from
d5ba4ee to
8752531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup module uses wpa_cli to configure networks. The default assumes:
This change adds support for connecting to open WiFi networks and networks where the SSID is hidden.
{ "interface": "wlan0", "ssid": "Example", "psk": "\"A_valid_passphrase\"" }For open WiFi networks the psk must be an empty string "psk": "".
{ "interface": "wlan0", "ssid": "OpenExample", "psk": "" }Unfortunately there isn’t a reliable mechanism to automatically detect that a network is hidden so an additional (optional) argument is needed when connecting to hidden networks.
{ "interface": "wlan0", "ssid": "Example", "psk": "20fcb529dee0aad11b0568f553942850d06e4c4531c0d75b35345d580b300f78", "hidden": true }