Use transaction BecomeAvailable when stopping transactions also when …

…this->status->get_state(connector) == ChargePointStatus::Faulted since the internal state of the state machine could be other then Faulted, which would lead to an unspecified transaction not moving back to Available (#865)

Signed-off-by: Piet Gömpel <[email protected]>

lib/ocpp/v16/charge_point_impl.cpp

@@ -4084,11 +4084,8 @@ void ChargePointImpl::on_session_started(int32_t connector, const std::string& s
 }
 
 void ChargePointImpl::on_session_stopped(const int32_t connector, const std::string& session_id) {
-    // TODO(piet) fix this when evse manager signals clearance of an error
-    if (this->status->get_state(connector) == ChargePointStatus::Faulted) {
-        this->status->submit_event(connector, FSMEvent::I1_ReturnToAvailable, ocpp::DateTime());
-    } else if (this->status->get_state(connector) != ChargePointStatus::Reserved &&
-               this->status->get_state(connector) != ChargePointStatus::Unavailable) {
+    if (this->status->get_state(connector) != ChargePointStatus::Reserved &&
+        this->status->get_state(connector) != ChargePointStatus::Unavailable) {
         this->status->submit_event(connector, FSMEvent::BecomeAvailable, ocpp::DateTime());
     }