Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WebSocket++ with libwebsockets #387

Closed
8 tasks done
hikinggrass opened this issue Dec 28, 2023 · 2 comments · Fixed by #846
Closed
8 tasks done

Replace WebSocket++ with libwebsockets #387

hikinggrass opened this issue Dec 28, 2023 · 2 comments · Fixed by #846
Assignees
Labels

Comments

@hikinggrass
Copy link
Contributor

hikinggrass commented Dec 28, 2023

A gradual switch from WebSocket++ to libwebsockets has begun in the last weeks of 2023. This will allow us to implement a few additional features that proved difficult to realize with the current implementation. Since this touches an essential part of the libocpp library, the switch will be done gradually and carefully. First a proof-of-concept implementation for TPM integration was realized, this will be followed by additional implementations for the plain and TLS websocket functionality. These will exist as a opt-in compile-time option at first, to facilitate testing. Once the new implementations have been sufficiently tested it will become the default and the old implementation will be deprecated and then removed at a later date.

  • Add initial libwebsockets based implementation for TLS with TPM support as a proving ground Added support for libwebsockets for tpm/secprofile 2/3 #320
  • Make libwebsockets integration compile time selectable
  • Refactor websocket interface to hide WebSocket++ implementation details
  • Implement plain and TLS websocket functionality with libwebsockets
  • Provide compile time selection between WebSocket++ and libwebsockets backend
  • Test and verify that both implementations behave the same
  • Deprecate the WebSocket++ backend
  • Remove WebSocket++ as dependency
@Pietfried
Copy link
Contributor

@AssemblyJohn please finish this up by removing websocketpp from libocpp. Please also rename the class WebsocketTlsTPM since it also covers non tls/tpm connections.

@AssemblyJohn
Copy link
Contributor

Solved with: #846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants