Harden message_callback against runtime error #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Suess <[email protected]>
Matthias-NIDEC
requested review from
Pietfried,
hikinggrass and
maaikez
as code owners
hikinggrass
requested changes
Dec 4, 2024
lib/ocpp/v16/charge_point_impl.cpp
Outdated
| } catch (const json::exception& e) { | ||
| EVLOG_error << "JSON exception during reception of message: " << e.what(); | ||
| this->message_dispatcher->dispatch_call_error(CallError(MessageId("-1"), "GenericError", e.what(), json({}))); | ||
| return; | ||
| } catch (const std::runtime_error& e) { | ||
| EVLOG_error << "runtime_error during reception of message: " << e.what(); | ||
| this->send(CallError(MessageId("-1"), "GenericError", e.what(), json({}))); |
There was a problem hiding this comment.
This send method has been removed, you should probably do something along the lines of:
auto call_error = CallError(MessageId("-1"), "GenericError", e.what(), json({}));
this->message_dispatcher->dispatch_call_error(call_error);There was a problem hiding this comment.
yes, updated ...
Signed-off-by: Matthias Suess <[email protected]>
hikinggrass
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In terms runtime errors during message handling avoid undefined behavior.
Issue ticket number and link
Checklist before requesting a review