[Feat] #4 SettingView - MySettingView 구현 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hongjaaa
commented
Oct 24, 2022
Comment on lines
86
to
112
| //List { | ||
| // Text(" 앱 버전 정보") | ||
| // .setBasicBody() | ||
| // .listRowBackground(Color.grayScale5) | ||
| // .listRowSeparatorTint(Color.white.opacity(0.2)) | ||
| // .listRowInsets(EdgeInsets()) | ||
| // Text(" 푸시 알림 설정") | ||
| // .setBasicBody() | ||
| // .listRowBackground(Color.grayScale5) | ||
| // .listRowSeparatorTint(Color.white.opacity(0.2)) | ||
| // .listRowInsets(EdgeInsets()) | ||
| // Text(" 라이센스 정보") | ||
| // .setBasicBody() | ||
| // .listRowBackground(Color.grayScale5) | ||
| // .listRowSeparatorTint(Color.white.opacity(0.2)) | ||
| // .listRowInsets(EdgeInsets()) | ||
| // Text(" 이용 약관") | ||
| // .setBasicBody() | ||
| // .listRowBackground(Color.grayScale5) | ||
| // .listRowSeparatorTint(Color.white.opacity(0.2)) | ||
| // .listRowInsets(EdgeInsets()) | ||
| // Text(" 도전 포기하기") | ||
| // .foregroundColor(Color.red) | ||
| // .listRowBackground(Color.grayScale5) | ||
| // .listRowInsets(EdgeInsets()) | ||
| //} | ||
|
|
There was a problem hiding this comment.
지우는 걸 깜빡해서 바로 수정해둘게요
Hongjaaa
commented
Oct 24, 2022
|
|
||
| import SwiftUI | ||
|
|
||
| struct MyProfileView: View { |
There was a problem hiding this comment.
MyProfileView의 레이아웃을 설정 탭에서 확인하고자 코드를 작성하였습니다.
작업하면서 수정될 코드들입니다.
Juhwa-Lee1023
approved these changes
Oct 24, 2022
Comment on lines
+17
to
+46
| HStack { | ||
| Text("앱 버전 정보") | ||
| .setBasicBody() | ||
| .padding(.leading, 36) | ||
| .padding(.top, 4) | ||
| .padding(.bottom, 2.55) | ||
| Spacer() | ||
| } | ||
| Divider() | ||
| .frame(width: 356, height: 1) | ||
| .background(Color.white.opacity(0.2)) | ||
| HStack { | ||
| Text("푸쉬 알림 설정") | ||
| .setBasicBody() | ||
| .padding(.leading, 36) | ||
| .padding(.top, 1.45) | ||
| .padding(.bottom, 2.55) | ||
| Spacer() | ||
| } | ||
| Divider() | ||
| .frame(width: 356, height: 1) | ||
| .background(Color.white.opacity(0.2)) | ||
| HStack { | ||
| Text("라이센스 정보") | ||
| .setBasicBody() | ||
| .padding(.leading, 36) | ||
| .padding(.top, 1.45) | ||
| .padding(.bottom, 2.55) | ||
| Spacer() | ||
| } |
There was a problem hiding this comment.
반복적으로 사용한는 HStack과 Divider를 따로 뷰로 만들 수 있을 것 같아요!
There was a problem hiding this comment.
List가 아닌 Stack을 사용하였는데, Stack을 더욱 잘게 만들어서 따로 뷰로 만들어보겠습니다!
감사합니다!
yeniful
approved these changes
Oct 24, 2022
Comment on lines
+23
to
+25
| .padding(.leading, 329) | ||
| .padding(.trailing, 46) | ||
| .padding(.bottom, 450) |
There was a problem hiding this comment.
padding을 한번에 묶어서 값을 줄 수 있을 것 같아요!
Comment on lines
+58
to
+65
| Divider() | ||
| .frame(width: 356, height: 1) | ||
| .background(Color.white.opacity(0.2)) | ||
| .padding(.bottom, -4) | ||
| Divider() | ||
| .frame(width: 356, height: 1) | ||
| .background(Color.white.opacity(0.2)) | ||
| .padding(.top, -4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Key Change
To Reviewers