Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not just respect vertical and horizontal but grid #3

Open
EagleoutIce opened this issue Aug 18, 2022 · 0 comments
Open

Do not just respect vertical and horizontal but grid #3

EagleoutIce opened this issue Aug 18, 2022 · 0 comments

Comments

@EagleoutIce
Copy link
Owner

Currently, the package only checks for the pixel above and below. However it would be nice if either:

  • diagonals can be checked as well (above left/north east, ...)
  • Patterns can specify custom guards that may access the complete qr code grid (e.g. to allow
    identification of part of the outer "ring" and therefore not draw/draw as ring"...

The second approach seems to be more efficient because we do not have to generate information for tiles that we do not need and that the only indirection is another macro expansion to produce that information. However, when identifying the pattern we know have to perform O(n) checks and can't just use the macro name. Maybe a hybrid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant