react aria compatible menu selection #1507
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Story:
https://menu-adjustment--63f50c7c86f6514d2e0ef4be.chromatic.com/?path=/story/components-menu--multiple-selection-with-select-all
View "Actions" panel to see how behavior reflects what is expected for React Aria selection. When selecting a list of items the returned keys are an array of items. When selecting "Select all" directly, the key returned is "all". This matches what is outlined here: https://react-spectrum.adobe.com/react-aria/selection.html#select-all
We'll also want to update the docs to note this.