Skip to content

Commit

Permalink
- Fix public accessibility of EasyPostTimeInTransitData class (closes #…
Browse files Browse the repository at this point in the history
  • Loading branch information
nwithan8 authored Mar 21, 2024
1 parent 74cb1d7 commit 44c670c
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## Next Releease

- Fix `EasyPostTimeInTransitData` class and `easypostTimeInTransitData` property of `EstimatedDeliveryDate` class being publicly inaccessible

## v7.1.0 (2024-01-08)

- Adds `allChildren` function in User service to get a paginated list of child users
Expand Down
10 changes: 10 additions & 0 deletions src/main/java/com/easypost/model/EasyPostTimeInTransitData.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package com.easypost.model;

import lombok.Getter;

@Getter
public class EasyPostTimeInTransitData {
private TimeInTransit daysInTransit;
private String easypostEstimatedDeliveryDate;
private String plannedShipDate;
}
6 changes: 0 additions & 6 deletions src/main/java/com/easypost/model/EstimatedDeliveryDate.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,3 @@ public class EstimatedDeliveryDate {
private Rate rate;
}

@Getter
class EasyPostTimeInTransitData {
private TimeInTransit daysInTransit;
private String easypostEstimatedDeliveryDate;
private String plannedShipDate;
}
3 changes: 3 additions & 0 deletions src/test/java/com/easypost/ShipmentTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,9 @@ public void testRetrieveEstimatedDeliveryDate() throws EasyPostException {
.retrieveEstimatedDeliveryDate(shipment.getId(), Fixtures.plannedShipDate());
for (EstimatedDeliveryDate estimatedDeliveryDate : estimatedDeliveryDates) {
assertNotNull(estimatedDeliveryDate.getEasypostTimeInTransitData());
assertNotNull(estimatedDeliveryDate.getEasypostTimeInTransitData().getEasypostEstimatedDeliveryDate());
assertNotNull(estimatedDeliveryDate.getEasypostTimeInTransitData().getDaysInTransit());
assertNotNull(estimatedDeliveryDate.getEasypostTimeInTransitData().getDaysInTransit().getPercentile99());
}
}
}

0 comments on commit 44c670c

Please sign in to comment.